Skip to content
OverviewSolutions
16
Comments
5
Yinon Hever
@yinonhever

All comments

  • Yinon Hever•835
    @yinonheverPosted almost 4 years ago

    Nice solution overall. My only note is that responsiveness needs to be improved: on mobile view padding needs to be added, and the filter area needs a little redesign so it won't look too dense on the small screen (see the mobile version of the design files).

    0
  • Arihant721•100
    @Arihant721Submitted almost 4 years ago

    How would we need to enable php processing on Github? I have one linked, in the event that the email is valid, to display a 'login successful' message.

    Basic form validation using JS

    2
    Yinon Hever•835
    @yinonheverPosted almost 4 years ago

    You don't need PHP to display login success message, you can do it with the frontend languages. The simplest way to do it is using the JavaScript alert() method, but if you want to customize the appearance of the success message, you can create such element with HTML/CSS and use JavaScript to show/hide the message.

    0
  • Yinon Hever•835
    @yinonheverPosted almost 4 years ago

    Nice solution. I love how you dynamically adjusted the max-height animation

    0
  • Yinon Hever•835
    @yinonheverPosted over 4 years ago

    Hey. I think the Vercel link is broken

    0
  • Yinon Hever•835
    @yinonheverPosted over 4 years ago

    Hey. The slider isn't working for me on desktop

    0