Gokulakrishnan G• 30
@DUMBLEDORE01
Submitted
Steph
@xStephx
All comments
- Steph• 500
@xStephx
Posted
Hi, congratulations on completing the challenge!
Your solution looks great, I will give you some suggestions for this project that you can use for better practice.
About your HTML in this project: You're using
<div>elements to wrap different sections of your content. You can use semantic HTML elements where appropriate, such as<article>,<header>,<footer>and other. Make sure to add appropriate alternative text (altattribute) to your<img>elements for screen readers and in case the images fail to load for better accessibility and SEO. The date is currently within<br>tags. Instead, consider using the<time>element with thedatetimeattribute for semantic markup of dates and times.About your CSS style in this project: You have
.containerdefined twice. It's better to styles into one block to avoid redundancy and make your code easier to maintain. In CSS,font-weighttypically takes numeric values ranging from100to900or keywords likenormalandbold. You're usingfont-weight: 500pxandfont-weight: 800px, which are invalid. Usefont-weight: 500;andfont-weight: 800;instead. You can add comments to your CSS code to it easier for you and others to understand your styling decisions and the structure of your code.To improve even more in this area, do more projects, ask for feedback, communicate with other developers, and keep dedicated!
I hope it helps you!
Have a nice coding!
Marked as helpful
15 - Alejandro Cañon• 220
@alecanonm
Submitted
Hi! i managed to do this challenge only with css and html, i tried to do it as fast as i can if you have some feedback to me, please leave it because that will help me to be a good developer in the future!!
greetings! 😊🌱👋🏻
Steph• 500@xStephx
Posted
Hi, congratulations on completing the challenge!
I will give you some suggestions for this project that you can use for better practice. Use max-width: for example 400px in main section not padding, and add some margin for left and right for example 10px for better responsive, and for img you can use width:100% for responsive on all screens!
I hope it helps you!
Have a nice coding!
Marked as helpful
9 - jabnakar• 20
@jabnakar
Submitted
Hey there! 👋 Just finished working on a social links card visual for a Frontend Mentor challenge. I'd really appreciate your feedback on the HTML and CSS code. Specifically looking for thoughts on the overall design, how it renders on different screens, and any ideas on code improvement. If you notice any have tips on best practices, I'm all ears! Thanks a bunch for your time and input!
Steph• 500@xStephx
Posted
Hello,
Your solution looks great, I have some suggestions for better coding practice and organization.
The first suggestion is to write your HTML and CSS in separate files for better overview, organization and practice.
The second suggestion is to use semantic tags for better accessibility, better organization.
The third suggestion is to use a Grid or Flexbox for centering and alignment system, this method is a quick and easy, time-effective.
The fourth suggestion is on social media buttons in this project to add hover for a better looking.
Have a nice coding!
Marked as helpful
4
