Skip to content
OverviewSolutions
31
Comments
537
P
visualdennis
@visualdenniss

All comments

  • shalri•620
    @shalriSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Implementing this challenge with NextJS made it more interesting. It gave me a broader scope for learning.

    I had so much fun with this challenge. It was challenging but well worth it. I am pleased with how I implemented the logic for the app. This really helped me develop a deeper understanding of hooks.

    What challenges did you encounter, and how did you overcome them?

    I still need to practice coding forms and using Typescript. Hopefully, these challenges will help me improve my proficiency.

    What specific areas of your project would you like help with?

    I am good for now. Learning so much from these challenges!

    Tip Calculator App - NextJs React Tailwind & Typescript

    1
    visualdennis•8,375
    @visualdennissPosted 6 months ago

    Hello,

    your solutions looks great and visually quite pleasing :) I like the smooth hover effects. One thing I'd like to suggest is, currently there seems to be a lot of useStates created. But since they are related states, they can be grouped together as an object. Something like this: const [state, setState] = useState({ bill: null, tipPercentage: 0, numberOfPeople: 0, customTip: "", tip: 0, total: 0, });

    This will make the state management cleaner and reduce the number of state updates, which can improve performance. Also it will be easier to keep track of what to update and when, and most importantly, keep them synced. I recommend digging this source as well on this topic: https://react.dev/learn/choosing-the-state-structure

    Hope this helps and keep up the great work! :)

    Marked as helpful
    1
  • Hira•130
    @hirashabeerSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Proud of using some new animations ,some pseudo class elements(actually always forget the difference bw pseudo elements and pseudo classes 😁 plz explain it to me),and using JSON data file...

    What specific areas of your project would you like help with?

    1=> I find it extremely difficult to make the website responsive to all screen sizes i just made to y screen then to min width of 375 px .... please share some techniques to make it responsive easily and share some resources to me where i can learn the responsive techniques .(is there any tool which could make the website responsive by it self by giving it the code of one screen size 😂 ) 2=> I always try to Make the code as short as possible as i think this is good approach and makes execution fast .is it a fact or just my myth😌 ..please check my code for any improvement in logic or cleanliness 3=> I found it difficult to make the bar on hover display "another" element popup in CSS so I had to write long code in js. pleaseeeeeee🙏 share a way to do it in css 5=> In the script.js file the last part commented out is not working for me why ?

    Expenses Chart Component

    2
    visualdennis•8,375
    @visualdennissPosted 6 months ago

    Hello Hira,

    To answer few of your questions: Pseudo-classes: define a special state of an element (e.g., :hover, :first-child). Pseudo-elements: style specific parts of an element (e.g., ::before, ::first-line).

    For mobile and general avoid giving fixed widths like 35px for the individual bar. they should be like 100%, and you can use display:grid for the #bars. E.g.: display: grid; grid-template-columns: repeat(7, 1fr); /* Create 7 equal columns */ and remove the fixed widths from the grid-items. And also add a max-width if you want for the bars so that they don't get too wide.

    as for the JS part. couldn't look in depth but, e.g. const popups = document.querySelectorAll(".popup"); is declared but not used since it is locally scoped inside the event listener func of DOMContentLoaded. Also I think instead of all those mouseOut event listeners, a simple :hover in CSS could suffice. Leading to cleaner and concise code.

    Hope this helps and keep up the great work! :)

    0
  • MarieG41•210
    @MarieG41Submitted 8 months ago
    What specific areas of your project would you like help with?

    I'd like some help for the Javascript part. I can make the second slider appear and the first one disappear, but I can't make the first one appear again.

    const prev = document.querySelector('.prev');
const next = document.querySelector('.next');
const testimonialOne = document.querySelector('.One');
const testimonialTwo =document.querySelector('.testimonial-2');

function nextTest() {
        next.addEventListener('click', function() {
        testimonialTwo.classList.remove('hidden');
        testimonialOne.classList.add('hidden');
    })
}
function PreviousTest() {
    prev.addEventListener('click', function() {
        testimonialTwo.classList.add('hidden');
        testimonialOne.classlist.remove('hidden');
    }) 
}

nextTest();
PreviousTest();

    Coding bootcamp testimonials slider with SCSS

    1
    visualdennis•8,375
    @visualdennissPosted 6 months ago

    Salut Marie,

    first of all, there is a typo inside ur second func: testimonialOne.classlist.remove('hidden'); it should be classList, which causes the problems.

    Secondly there is no need to wrap ur eventlisteners into a function just to call them. Also, it's better practice to set up your event listeners outside of the function definitions, ensuring they are added when the DOM is fully loaded, smth like so:

    const prev = document.querySelector(".prev"); const next = document.querySelector(".next"); const testimonialOne = document.querySelector(".One"); const testimonialTwo = document.querySelector(".testimonial-2");

    function nextTest() { testimonialTwo.classList.remove("hidden"); testimonialOne.classList.add("hidden"); }

    function previousTest() { testimonialTwo.classList.add("hidden"); testimonialOne.classList.remove("hidden"); }

    // Set up event listeners

    next.addEventListener("click", nextTest);

    prev.addEventListener("click", previousTest);

    Hope this helps! :)

    Marked as helpful
    1
  • WasiArshad•30
    @WasiArshadSubmitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    This project put me the extra pressure and that's leads me to work hard get to know many new things in the different ways.

    What challenges did you encounter, and how did you overcome them?

    I was unable to show popup button seamlessely but later on I tried and learn from other third party websites.

    What specific areas of your project would you like help with?

    I can me more helpful in the HTML and CSS .

    Article Preview Component using flexbox

    1
    visualdennis•8,375
    @visualdennissPosted 7 months ago

    Hello there,

    great job completing this successfully! Few suggestions for further improvements:

    • Add a little bit more gap between 'Share' and button icons.
    • No need to choose headers based on their size, e.g. h5 to get a smaller. Headings on a page should follow an order, h1 , h2 etc. and use CSS to change their style.
    • Consider using media queries to add responsiveness for mobile view.
    • Variable naming in JS looks a little confusing, as one would except 'buttons' would be multiple buttons, but you are just selecting one button, so better to name as 'button' etc.

    Hope these recommendations are helpful!

    0
  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Hello Olena,

    great solution, looks almost identical to the design :)

    there seems to be some areas to improve on regarding best practices of accessibility. For example: setting a fixed height like max-height: 450px; to a text containing element might cause various issues like content overflow with changing data or when user changes base font size on their device etc.

    Also, for similar reasons it is better to use responsive units like rem/em than px.

    there is also a great article about this particular FEM Challenge, showing and explaining best practices: Product Preview Card, feel free to check it out :)

    Hope you find this feedback helpful! Keep up the great work!

    Marked as helpful
    0
  • Jo Young•840
    @Jo-cloud85Submitted over 1 year ago

    This challenge was completed with:

    • dark and light theme toggle
    • the ability to switch users that also comes with a tiny bit of animation
    • pop-up alerts when users try to send an empty response or vote more than once
    • sync data with localStorage for any CRUD operations

    Due to this challenge's multiple state management requirements, I used a lot of function declarations, instead of function expressions, which I understand is not ideal. Also, there still might be some bugs lying around. Nevertheless, I had fun drilling my Javascript skills.

    Interactive Comments Section [vanilla JS]

    3
    visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Hey Jo,

    great work! This one is a quite tricky challenge and u have did an amazing job :)

    There seems to be little issue with the vote system. Once u vote, if u can only cancel that vote but u cannot vote the opposite way. E.g. if u upvote, it goes up to 5, but if u downvote it never goes to 3, which should be the case. I've listed here Vote System States. Also i dont think it is necessary to put an explicit warning to a user. The standard practice on web is to toggle when clicked twice, instead of a pop up alert.

    Its also very nice that u added little menu to switch users. I've also initially wanted to make a menu like u and display users with animation onClick, then i thought since this is a demo, people might not spend time much, so i wanted to make it very explicit. But if it was a real-world thing, i'd hide them into a menu too.

    Hope you find this feedback helpful! Keep up the great work ;)

    Marked as helpful
    0
  • Adriana•60
    @AdrianaMagdalenaSubmitted over 1 year ago

    Project built with:

    • Flexbox
    • Grid
    • Mobile-first design
    • CSS custom properties

    I had hard time deciding where the mobile view would change to desktop, so I added design for tablet in the middle.

    I'll appreciate any feedback!

    Stats preview card using flexbox and grid

    1
    visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Great work Adriana!

    you can add breakpoints anywhere you need, the given design images with 375px and 1440px show only how the app should look like at that particular browser width, so you are free to choose where to add breakpoints. It is usually best to check the look of your app for sizes as small as 320px and up to 2500px. Adding tablet is always recommended. Keep up the good work!

    Marked as helpful
    0
  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Hello Mermaido,

    Good effort! I've couple of suggestions to improve further:

    first, u need to change your html structure, not the body but a <main> should be the container for these elements and do not give any fixed height, only a max-width is enough. You can make the image width:100%, which will grow as much as it can until it hits containers max-width. You can then add a padding so there is little white space between image and the containers borders.

    To center the QR card inside the body, u can use display: grid; place-items: center; min-height: 100vh;

    I also recommend you to check my solution for the QR code for further ideas: SOLUTION LINK

    Hope you find this feedback helpful!:)

    Marked as helpful
    2
  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Amazing job Mikolay! You are clearly talented and make very fast progress. Keep pushing your boundries 🔥

    Small tip when submitting: you can temporarily turn off the animations on your code before taking a screenshot on FEM, after you generated the screenshot here you can enable the animation in your code again so the live demo has animations. This way, all parts of your app will be visible in the screenshot.

    0
  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Great job with the creative touches in this one! Always love to see the work of people who keep pushing the boundries, keep it up that way and looking forward to see more 🔥

    0
  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Hey Reymart!

    Great job on completing this complex challenge successfully! Final result looks good.

    Few suggestions to improve further:

    • Ideally, users should be increase/decrease the vote number only once but currently one can upvote the same comment infinitely.
    • Every clicking on "Reply" keeps opening new input field, it would be better to use a toggle logic instead, where first click on the button displays the add comment input field and the second click hides it.

    Hope you find this feedback helpful!

    Marked as helpful
    0
  • visualdennis•8,375
    @visualdennissPosted over 1 year ago

    Hello Sandra :)

    congrats on completing the challenge successfully! Nice result.

    However there seems to be couple issues to work on. To name a few: Giving a height: 60vh; is not a good idea, because it will stretch and squeeze depending on the screen size and cause unwanted paddings etc. It is best to avoid giving any fixed height or a height using percentages like this, instead just let the content of container determine the height. Use paddings and margins instead to tweak the look.

    The color of the body text seems to be too bright, so using a darker value would improve the contrast and reability.

    Hope you find this feedback helpful!

    Marked as helpful
    0