Skip to content
OverviewSolutions
20
Comments
4
Vikram Ingleshwar
@vikramvi

All comments

  • Vikram Ingleshwar•280
    @vikramviPosted over 2 years ago

    Hey Malik,

    Can you ping me on slack ? My user name is "Vikram"

    We've study + accountability group, if you're building projects; you can join us as well

    Our plan is to build all the projects from FM website ( HTML-CSS and JS )

    Regards, Vikram

    --- ignore below---

    Does the solution include semantic HTML? Is it accessible, and what improvements could be made? Does the layout look good on a range of screen sizes? Is the code well-structured, readable, and reusable?

    0
  • Rafael Takano•180
    @rafaeltakanoSubmitted over 2 years ago

    Hi everyone! 👋

    I'm not so sure about the way I made the testimonials three-column design for desktop. Is there a better way to do it?

    Also challenged myself to implement dark-mode. It's only visible when you change it on your browser settings cause I didn't use any JS. Is there a better way to do it?

    Any feedback is welcome, specially for accessibility with my html/component!

    Social proof section solution

    1
    Vikram Ingleshwar•280
    @vikramviPosted over 2 years ago
    1. I checked your GH profile and has got below suggestions & queries

    1.1 You could have used semantic tags in index.html to make it SEO friendly

    1.2 Please clarify why did you use sass instead of plain CSS ?

    1.3 I didn't understand how did you manage to put 3 testimonial at different level ?

    Does the layout look good on a range of screen sizes? YES

    Is the code well-structured, readable, and reusable? YES

    2
  • Vikram Ingleshwar•280
    @vikramviPosted over 2 years ago

    Thanks for sharing your project, it looks simply amazing.

    I've looked into the GH repo and have below doubts, please clarify

    1. What's the reference for this structure of css ? components directly and breaking down into individual components Usually all the styling is done in single file style.css

    Please clarify your philosophy behind this practice ?

    1. I didn't understand below in page.css &__main { &__footer {

    are inside .page class, how does that work ? Any reference please

    1. What's this particular naming convention ? page__main, card__container etc
    1
  • Vikram Ingleshwar•280
    @vikramviPosted over 2 years ago

    Can you please clarify without using height property how did you make image size matching as per design ?

    I couldn't find height being set either for .qr-card or img

    ----- Adding below as short feedback / answer is not allowed here :)

    Does the solution include semantic HTML? - NO Is it accessible, and what improvements could be made? - NO Does the layout look good on a range of screen sizes? - YES Is the code well-structured, readable, and reusable? - YES

    1