If the code is clear and easy to read, if the HTML is structured semantically, if the CSS stylesheet is well-organized, and if there is a more efficient way to accomplish a specific task.
Vigh Roland
@vighgivAll comments
- @ccadubrSubmitted about 2 months agoWhat specific areas of your project would you like help with?@vighgivPosted about 2 months ago
Using the
px
unit forfont-size
is not recommended because it is not accessible. When users adjust their browser’s default font size, the text on your site will remain fixed at thepx
value you set. Userem
instead ofpx
.For more details, you can check out this blog post.
Personally, I recommend a helpful VS Code extension called px to rem & rpx & vw (cssrem) to effortlessly convert between these units.
Hope this helps!
1 - @Atharva90gitSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
After log time completed this basic frontend project. I enjoyed this development process. i will try to complete it more faster way.
@vighgivPosted about 2 months agoThis looks really promising! A few small tweaks could make a big difference:
- Never set fixed widths, instead use
max-width
as it will prevent overflowing. - Be careful when using percentages for width. You can see that at the 601px breakpoint the card becomes very narrow. What do you think you should replace
width: 27%
with?
Marked as helpful0 - Never set fixed widths, instead use
- @thaisramospSubmitted about 2 months ago@vighgivPosted about 2 months ago
I would adjust the
padding
and addbox-shadow
, then everything should line up perfectly!0