@nati-pi
Submitted
@v-codey
@nati-pi
Submitted
@v-codey
Posted
hey @nati-pi ,
the problem with your solution is not hidden, you can also see there are issues. However I suggest some things that will probably fix it.
height: 28rem;
& width: 13rem;
in the .padd
so that the button doesn't flow outp
with a min-height of 11 to 14rem
. ( the issue with btn margin-top here is that the button position is dependent on the text length if the text is more then the button will not be aligned with each other).keep learning happy coding
Marked as helpful
@BlackSheldt
Submitted
@v-codey
Posted
hey @BlackSheldt congratulations on completing your first challenge.
there are some issues with your design.
%
as units works not that great at times, I suggest using px or rem.overall you did good.
keep learning happy coding 👍
@vijay0609
Submitted
@v-codey
Posted
Hey @vijay0609,
Great Job on the challenge. Very close to the provided design. kudos
however there are somethings which i would like to mention
rem
instead of px
especially in width, heights and font-size.body {
display: flex;
align-items: center;
justify-content: center;
min-height: 100vh;
}
hope its helpful for you. keep learning happy coding
Marked as helpful
@PatelNikhil-08
Submitted
@v-codey
Posted
Hello @PatelNikhil-08 ! Congratulations on completing this challenge
There are a few suggestions I would like to give you
main
tag inside bodya
tag . Do not remove it, rather replace the div
with footer
<body>
<main class="container">
<-- Your code -->
</main>
<footer class="attribution">
Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
Coded by <a href="Your profile link"> your name </a>.
</footer>
</body>
I hope it was helpful, keep learning happy coding.
@maestroeffect
Submitted
@v-codey
Posted
hey @maestroeffect
I reviewed your code you've done a good job just needed some tweak and use different technique. check your github repo.
position
with hard coded value of position left: 20rem
,top: 15rem
to make card side by side is not very smart choice according to me.those were some of my observations, keep learning happy coding.
Marked as helpful
@Briancarlo24
Submitted
Please check my code. I believe I have improved with coding since I first started. I just want to know what you would have done differently with this challenge?
@v-codey
Posted
Hi @Briancarlo24, Really good job on the challenge, Just few things you may haven't done right
body
background color isn't setthat was my few observations. Happy Coding
Marked as helpful
@FloriMartin
Submitted
It was my first time at trying responsive desing. To be honest, I'm not quite sure how I made it worked. And I don't know why in the smallest resolution (using the dev tools of chrome) the image it's not in the middle. But it was fun anyways.
@v-codey
Posted
hey @FloriMartin, Good job on your first challenge. I saw your code, there are few things I would like to mention
main
tag inside body
see this solution for better understandingpadding: 20px 20px 20px 20px
- > padding: 20px
will give same results. read morehappy coding.
Marked as helpful
@SilverWings47
Submitted
Any feedback would be appreciated.
@v-codey
Posted
hey @SilverWings47, Good job on the challenge. my few observations
:root
would make things easy for you. read morewidth
with help of rem
or em
or px
would be better in this fixed sized card, because of % when the width shrinks the the image shrinks with it but not the card.attribution
div to footerhappy coding 👍
@darthTh0t
Submitted
Hi there developers. First time doing this sort of challenge. I would appreciate your feedback and will definitely implement it in my future projects.
@v-codey
Posted
hey @arnav-sahoo, Good job on your first challenge. I saw your source code, there are few things I would like to add.
main
tag inside body
For more inforoot
not recommended its a pseudo selector read morebr
read morehappy coding. 👍
@bodashideung
Submitted
Any feedback from you will help me a lot on my journey to become a web developer.
@v-codey
Posted
hey @bodashideung,
Excellent work done there. while submitting solution select tags like sass/scss
etc. if you have used it in project.
Marked as helpful
@callmeog01
Submitted
Hello developers, I would like a review on my code to know if what built is best practices
@v-codey
Posted
hey @callmeog01, good work on this challenge there are some issues with the html , my browser is telling me this site is unsafe. so i reviewed the code and done some important changes . check out your github
Marked as helpful
@leoimewore
Submitted
Feedback always wanted. I to read-up on the behavior of images in flex and went back to this task.
@v-codey
Posted
Hey @leoimewore, You did a good job.
there are few things which you should looking out for e.g.
:root
and use them with help of var( )
.Check out this solution for any queries regarding this solution feel free to reach out. That all from my side, happy coding.
Marked as helpful