Hi, this is my first submission to frontend mentor.
It would be great to have some feedback on my solution.
Thank you in advance :-)
Matthew
@unhommequidort
All comments
- Matthew• 60
@unhommequidort
Posted
This is looking really nice!
One thing I'd point out is that if you look closely at the design, the border-radius on the image is a bit smaller than that of the surrounding card container, so that the width of the white around the image stays the same as it follows the corners.
Keep up the great work!
0 - David H.• 40
@DavidDHDH
Submitted
Hello community ! This is my solution for my first challenge.
Looks simple but I got 2 issues :
- how to center vertically my card ? I've tried using Flexbox but as the body doesn't have height it' still at the top (so I've put a margin-top 100px)
- my card looks contract after uploading, compare to my screenshot and the render in my IDE, any idea ?
Let's go for the second one now !
Matthew• 60@unhommequidort
Posted
You can add a height: 100vh property to the body to make it take up 100% of the window's visible vertical space.
Marked as helpful
0 @Haitham-sh
Submitted
Matthew• 60@unhommequidort
Posted
Nice work on this one! If I can permit myself one bit of advice, I recommend checking out flexbox, specifically the justify-content and align-items properties, for centering your card horizontally and vertically in the window, no matter what size the window is.
Keep up the good work!
Marked as helpful
0
