QR code component solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <section> with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  For a responsive content, replace the width in the section/main with max-width and give the img a a max-width of 100% instead of a fixed width value.

  To center the section on the page using flexbox or grid instead of a margin:

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Give h1 and p the same margin-left and margin-right values.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Matthew•60

  @unhommequidortPosted over 1 year ago

  Nice work on this one! If I can permit myself one bit of advice, I recommend checking out flexbox, specifically the justify-content and align-items properties, for centering your card horizontally and vertically in the window, no matter what size the window is.

  Keep up the good work!

  Marked as helpful

  0