Skip to content
OverviewSolutions
3
Comments
3
Maycon
@traceurmaycon

All comments

  • Maycon•70
    @traceurmayconPosted over 2 years ago

    Nicely done. You have to update your report to take away this accessibility issue. To answer your question. You did great with the properties. If you are talking about centralize the layout, you have to make body 100% of the viewport height and use flex in it. Align horizontally with justify-content: center and vertically with align-items: center. Didn't test this myself, but that's the general idea.

    UPDATE: You updated the report while I was writing this comment so desconsider this part. Congratulations for the amazing work.

    Marked as helpful
    0
  • Maycon•70
    @traceurmayconPosted over 2 years ago

    Hello there. Congratulations for completing the challenge. I took a time to review your code and I have some points to add.

    1. You have a few issues with algorithm that, in resume, you can solve just adding alt to your image and put all your content into a <main> tag and the .atribution class inside a <footer> tag.
    2. You have more space on the right side of the card than the left. Centralize it!
    3. Your <h3> must be substituted to a <h1> since all pages must have one. And you have to adjust the size of it.
    4. You need to change the colors of the texts.
    5. You can centralize your card using flexbox. Absolute positioning is a no-no since you don't have responsiveness with it. Just using media queries.
    6. To finish, I always say that "less is more". So you can throw all useless code like the <div>s wrapping the image and the title. You don't need 'em.

    But great job. It's great to be willing to at least try to do it. And it's even better to get it. Congratulations again.

    PS: Sorry for the bad english. I'm still learning. xD~

    Peace!

    0
  • Julio Velezmoro•220
    @LakorthusSubmitted over 2 years ago

    soorryy guys this background was a challenge.. i could not see it properly =( can someone send me a push of the bg?

    many thanks

    Social Proof Section

    1
    Maycon•70
    @traceurmayconPosted over 2 years ago

    I had the same problem with the background. Anyway, you have to adjust your font-weights and your project will be crispy.

    Marked as helpful
    1