QR Code Component

Community feedback

• 

  Maycon•70

  @traceurmayconPosted over 2 years ago

  Hello there. Congratulations for completing the challenge. I took a time to review your code and I have some points to add.

  1. You have a few issues with algorithm that, in resume, you can solve just adding alt to your image and put all your content into a <main> tag and the .atribution class inside a <footer> tag.
  2. You have more space on the right side of the card than the left. Centralize it!
  3. Your <h3> must be substituted to a <h1> since all pages must have one. And you have to adjust the size of it.
  4. You need to change the colors of the texts.
  5. You can centralize your card using flexbox. Absolute positioning is a no-no since you don't have responsiveness with it. Just using media queries.
  6. To finish, I always say that "less is more". So you can throw all useless code like the <div>s wrapping the image and the title. You don't need 'em.

  But great job. It's great to be willing to at least try to do it. And it's even better to get it. Congratulations again.

  PS: Sorry for the bad english. I'm still learning. xD~

  Peace!

  0

  ---

  

  joey•30

  @joeygilPosted over 2 years ago

  @traceurmaycon thanks for the feedback, Maycon! Your English is great, don't worry. I'm very new to all this so appreciate you taking the time to help me with it.

  0