I have learned a lot from this project. This is my second solve on the platform and I liked it very much now as to make solve of the challenges which gives the feel of working real world projects. If you find any mistake or want to give any suggestions . Feedback will be appreciated. Thank You !
Jordan B.
@totototoetoAll comments
- @aayushsingh-459666Submitted almost 3 years ago@totototoetoPosted almost 3 years ago
Hello, it's a cool work ! I have few suggestions to help you improve your code.
-
Remove
width: 99vw; min-height: 100vh;
and addheight:100vh
in.container
, block elements are always 100% width of their parent width -
Factorize multiples Flex-box patterns like vertical/horizontal center for example by creating a class like this :
.wrapperCenter { display:flex; align-items:center; justify-content:center; }
-
Avoid setting height of a element in your code, height should preferably always depend on the content, not on a predefined value ex
height: 600px;
-
It seems you don't have a mobile first approach. For example, you set the width of your card to 350px at the beginning of your CSS code. When you should do the opposite
-
You can create an element with a responsive width without media query as follows: .responsiveWidth
{ width:87.2%; // (320/375)*100 max-width:350px // normalize width }
Marked as helpful1 -