All comments

• 

  P

  innitman•130

  @innitmanSubmitted 4 months ago

  What are you most proud of, and what would you do differently next time?

  It's getting easier the more I do :)

  One issue is accessibility. I tried adding 'a' but it doesn't seem tab navigatable. I will read into tab index and aria more.

  What challenges did you encounter, and how did you overcome them?

  Did this without the Figma, so it won't be pixel perfect.

  What specific areas of your project would you like help with?

  I need to read into tab index and aria more. Any advice on helping make it more keyboard accessible appreciated :)

  

  Divitis still...

  2

  30
  

  tlvk•60

  @tlvkPosted 4 months ago

  Looks great! I tested your site with a screen reader and it seems to be working fine! The only thing I would maybe do is change the alt text of the profile picture to something like "avatar" or "profile picture" since now the screen reader reads the name twice. But otherwise it's very good and the aria-label for the link <div> was a great idea!

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Kostexx•120

  @KostexxSubmitted 4 months ago

  What are you most proud of, and what would you do differently next time?

  I'm getting used to using variables.

  What challenges did you encounter, and how did you overcome them?

  I used the clamp function in css for the main container, but I had to try many different values to get the desired result.

  What specific areas of your project would you like help with?

  Any constructive criticism is welcome.

  

  Social Links Profile with HTML and CSS

  1

  40
  

  tlvk•60

  @tlvkPosted 4 months ago

  Looks super good! I like the animation you added to the color change of the buttons/links, it makes the site feel nice and polished. I have one improvement idea though: it would probably be a good idea to use an anchor <a> element for the links on the page so that screen readers announce them as links to external pages.

  Marked as helpful

  0