All comments

• 

  lucas souza•30

  @lucasdeabrilSubmitted almost 2 years ago

  this was a good start for me

  

  just apply what I learned

  2

  10
  

  Yohannes Teshome•140

  @tiobistaPosted almost 2 years ago

  Hey there it was a nice try it would be better if if you use a media query to display on different devices you can refer more on https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

  0
• 

  IbnuKhathir•40

  @IbnuKhathirSubmitted almost 2 years ago

  I am still learning. so any feedback will be very helpful. especially for the problem of changing device sizes

  

  Product Preview Card Component {HTML and CSS}

  1

  10
  

  Yohannes Teshome•140

  @tiobistaPosted almost 2 years ago

  It is a nice project and you can also improve by using a picture html tag rather than using two images like <picture> <source srcset="/media/images/img1.jpg" media="(min-width: 315px)"> <img src="/media/images/img2.jpg" alt=""> </picture> You can find it from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture.... to make it valid html5 semantics .

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Hardik•20

  @Harrrdik18Submitted almost 2 years ago

  I somehow was able to make this but the code seems a complete mess to me any feedback will be appreciated

  

  Prodcut card page

  2

  70
  

  Yohannes Teshome•140

  @tiobistaPosted almost 2 years ago

  Hey this a nice project , It would better if you use a valid html5 semantics to validate head to https://www.freeformatter.com/html-validator.html and paste your html code and validate it, additionally on medium and large skins texts are outflow from the card ... try to measure the pixels of the design jpg ... so that yoi can build a project closer to the the design ...

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  EDOARDO PITACCIO•180

  @EdoPitoSubmitted almost 2 years ago

  Could not round some of the corners, is it because the image is actually a background image that has no repeat and only covers 50% of the card?

  Any other feedback is welcome!!!

  

  Product preview card

  5

  20
  

  Yohannes Teshome•140

  @tiobistaPosted almost 2 years ago

  I think you can put the image inside a div container and give the container a border radius... so that you can get the image with rounded corner

  0