Skip to content
OverviewSolutions
8
Comments
4

Yohannes Teshome

@tiobistaADDIS ABABA , ETHIOPIA140 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

I’m currently learning...

I am currently Learning

Latest solutions

View more solutions

Latest comments

  • Yohannes Teshome•140
    @tiobistaPosted over 2 years ago

    Hey there it was a nice try it would be better if if you use a media query to display on different devices you can refer more on https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

    0
  • Yohannes Teshome•140
    @tiobistaPosted over 2 years ago

    It is a nice project and you can also improve by using a picture html tag rather than using two images like <picture> <source srcset="/media/images/img1.jpg" media="(min-width: 315px)"> <img src="/media/images/img2.jpg" alt=""> </picture> You can find it from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture.... to make it valid html5 semantics .

    Marked as helpful
    0
  • Yohannes Teshome•140
    @tiobistaPosted over 2 years ago

    Hey this a nice project , It would better if you use a valid html5 semantics to validate head to https://www.freeformatter.com/html-validator.html and paste your html code and validate it, additionally on medium and large skins texts are outflow from the card ... try to measure the pixels of the design jpg ... so that yoi can build a project closer to the the design ...

    Marked as helpful
    1
  • Yohannes Teshome•140
    @tiobistaPosted over 2 years ago

    I think you can put the image inside a div container and give the container a border radius... so that you can get the image with rounded corner

    0