All comments

• 

  Katerina Sarantopoulou•160

  @kate-sarantSubmitted over 2 years ago

  I really like this project because it helps me extent my skills in responsive design and i really enjoyed. I'm open for any feedback or recommendations .

  

  QR-code_compoment_flexbox

  1

  20
  

  Alejandro•100

  @thealexgonzoPosted over 2 years ago

  Hey,

  Well done on completing the challenge! There's a few things that you missed, so I'll just add my feedback below as a numbered list:

  1. You can add the font specified by adding the following code to you HTML head tag:

  <link rel="preconnect" href="https://fonts.googleapis.com" /> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" rel="stylesheet" />

  Don't forget to then also add it to the body font-family in your CSS file.

  2. To fix the accessibility issues instead of using a <section> tag in your body to wrap the code around use a <main> tag instead.

  3. If you set the width dimensions to 320 px of 32 rem it will get your solution looking a lot closer to the design.

  4. <p>Improve your front-end skills by building projects</p> should be an <h1> instead of a <p>

  Good luck ; )

  Marked as helpful

  1
• 

  lsh•160

  @SH-Lee2Submitted about 3 years ago

  Hello, I'm preparing for a front-end developer. It was hard to make an css during the challenge, but let me know if there is a problem after looking at this. Sorry for my bad english(Thank you 😁)

  

  using HTML5 and CSS

  2

  10
  

  Alejandro•100

  @thealexgonzoPosted about 3 years ago

  Instead of having the preview card occupy the full width, you can give it a percentage width, for example 80% is common one and the set the top and bottom margin to 0 and the left and right margin to auto like so:

  width: 80; margin: 0 auto;

  0