using HTML5 and CSS

Community feedback

• 

  Alejandro•100

  @thealexgonzoPosted about 3 years ago

  Instead of having the preview card occupy the full width, you can give it a percentage width, for example 80% is common one and the set the top and bottom margin to 0 and the left and right margin to auto like so:

  width: 80; margin: 0 auto;

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, your solution looks fine but I have a few suggestions for you:

  1. Your font-family doesn't work (or forgot to add it?).

  2. You are using <span> excessively. It's not really a semantic tag and while it's fine to use it when needed (for inline styling, like for the "insights" word in this challenge), it should not be used instead of more semantic html tags like headings and <p>

  3. The outer section could be swapped for main to get rid of the issues in the accessibility report.

  0