Skip to content
OverviewSolutions
3
Comments
3
Thalia
@thaliawoods

All comments

  • Thalia•70
    @thaliawoodsPosted 1 day ago

    Your solution looks great, congrats!!!!

    The HTML structure is clean and well-organized, and the CSS is easy to read. Using a reset CSS file is a very good idea for consistent styling across all browsers.

    Maybe consider breaking down the HTML structure into smaller React components, passing dynamic data as props, and using event handlers or React Router for navigation.

    But these are really minor details, and overall, in my opinion, you did a perfect job :)))

    2
  • Thalia•70
    @thaliawoodsPosted 6 days ago

    Good job for your solution!! 🐛

    For accessibility, maybe the role="article" should be applied to the <main> element, not to the <p> element.

    Also, a minor detail but there is an extra space in the closing tag of the <div class="tag" > element.

    In the @font-face, it should be format('truetype') instead of format(truetype).

    And in my opinion, maybe it would be better if the .illustration class should be styled directly, not nested within .card.

    Globally, it is very good! (Maybe yours is a tiny bit bigger than the design but it's really nothing :3)

    Marked as helpful
    2
  • Thalia•70
    @thaliawoodsPosted 6 days ago

    Midonour could have used <main></main> for better accessibility, but that's all I can say because everything else seems good! :)

    Marked as helpful
    1