Design comparison
Community feedback
- @thaliawoodsPosted 15 days ago
Good job for your solution!! 🐛
For accessibility, maybe the role="article" should be applied to the <main> element, not to the <p> element.
Also, a minor detail but there is an extra space in the closing tag of the <div class="tag" > element.
In the @font-face, it should be format('truetype') instead of format(truetype).
And in my opinion, maybe it would be better if the .illustration class should be styled directly, not nested within .card.
Globally, it is very good! (Maybe yours is a tiny bit bigger than the design but it's really nothing :3)
Marked as helpful2@rodolfohgcPosted 15 days ago@thaliawoods merci, Thalia ! Je vais mettre en œuvre certaines des améliorations suggérées (et cela sera l'occasion de pratiquer mon français).
1@thaliawoodsPosted 14 days ago@rodolfohgc je t'en prie Rodolfo ! (tu as l'air de bien t'en sortir pour l'instant avec le français haha)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord