Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P
    Asv000 190

    @Asv000

    Submitted

    What are you most proud of, and what would you do differently next time?

    That I managed to style lists and tables! Note for future me: If you will comeback to this later on, use SASS because your CSS file is a mess.

    What challenges did you encounter, and how did you overcome them?

    Definetly styling lists and tables. I did a lot of MDN research about ul, li and tables which helped me with that task.

    What specific areas of your project would you like help with?

    If semantic is correct

    @tagutirayane

    Posted

    Hey!

    Congratulations on finishing your project.

    I'm a newbie on web development, but I would recommend maybe CSS Grid instead of tables. It would make your life a little bit easier.

    Also, maybe not every thing needs a class right now, but really, I wouldn't know at this point kkk

    Marked as helpful

    1
  • TheVolky 30

    @TheVolky

    Submitted

    What are you most proud of, and what would you do differently next time?

    That was really close from the last challenge so i'm not really proud about something particuraly.

    What challenges did you encounter, and how did you overcome them?

    I dont think i encounter a challenge.

    What specific areas of your project would you like help with?

    I just want to know what i did wrong and what i can improve and what is the best practice i didn't use ?

    @tagutirayane

    Posted

    First of all, you are using sooo many divs, this might not be necessary. For example, this example is cleaner and works just as fine, adjusting css:

    <div class="flexbox"> <img src="assets/images/avatar.png" alt=""> <h1>Name</h1> <h2>Location</h2> <p>"Front-end developer and avid reader."</p> <div class="box-links"> <a href="https://github.com/">Github</a> <a href="https://www.frontendmentor.io/">Frontend Mentor</a> <a href="https://www.linkedin.com/">LinkedIn</a> <a href="#Twitter">Twitter</a> <a href="#Instagram">Instagram</a> </div> </div>

    This would minimize your html and css a lot, try it if you want =)

    0
  • P

    @mussieh

    Submitted

    What are you most proud of, and what would you do differently next time?

    Just used flexbox for centering the card.

    What challenges did you encounter, and how did you overcome them?

    No big challenges faced.

    What specific areas of your project would you like help with?

    I would like feedback on my code if I made a mistake somewhere.

    @tagutirayane

    Posted

    I just find a little weird to use so many broken numbers as "em" and "rem", but I really don't know what is the standard practice.

    Also, it is new for me the use of three different stylesheets, but it can be more organized, I liked it.

    I'm sorry I can't give any specifics feedbacks, because it seems fine for me and I am just a begginer =)

    Marked as helpful

    0
  • snhaydar 20

    @snhaydar

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud that I was able to create this project in just a few hours. I have coded in these languages before, but not well and not for a very long time. Next time, I will try to apply these new skills to break down the problem in a more orderly way instead of all willy nilly.

    What challenges did you encounter, and how did you overcome them?

    I encountered problems with the spacing, padding, Google Fonts -- even setting up the project was quite a challenge for me. I overcame them by searching my problems on Google and was able to troubleshoot solutions.

    What specific areas of your project would you like help with?

    Here are a few things I would like help with:

    1. How can I make my code more efficient/readable? Are there things that I did that seem convoluted or could be done in a simpler way? Are my names descriptive enough?
    2. What could I have done better to get a pixel-perfect site? I had to play around with a lot of the pixel amounts and wasn't sure if I should be doing something to get padding that perfectly matched the Figma file. (Ex: Look at my "card" class in my CSS file. I just chose 14px because it looked somewhat right. What could I have done to get the right value instead of guessing?)

    @tagutirayane

    Posted

    Hey!

    Your HTML file is great. It is awesome that you found a solution different than mine. Maybe using "display: flex" at the body component would be easier to space things out without having to create a new class (the container) to work with the text.

    One site that always helps me with flexbox is this one: https://css-tricks.com/snippets/css/a-guide-to-flexbox/

    Abraços from Brazil!

    0