All comments

• 

  Fatma Tawfeek• 100

  @Fatma-Tawfeek

  Submitted 20 days ago

  What are you most proud of, and what would you do differently next time?

  • organization of the code
  • using semantic HTML

  What challenges did you encounter, and how did you overcome them?

  • make "ul" element take the 100% of the card using max-width
  • I used the width property instead of max-width

  What specific areas of your project would you like help with?

  • adjust spaces between text and other elements

  

  Social links profile

  1

  30

  

  P

  tagoras• 50

  @tagoras

  Posted 20 days ago

  I would suggest the following changes:

  1. Increase the overall size of the card, including font-size, margins and paddings. You can do this by setting html{font-size: 62.5%} and then setting the font-size to an appropriate amount in your card container using rem units. Same with margins and paddings.
  2. Decrease the margin between the person's title and the location.
  3. Increase margin of links, make the name of each social link bold (font-weight: bold or using an appropriate numerical amount).

  Nice solution!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Ebube Amadi• 130

  @ebubz-dev

  Submitted 20 days ago

  

  Blog Preview Card

  1

  20

  

  P

  tagoras• 50

  @tagoras

  Posted 20 days ago

  Add more padding in the card. Additionally, you should increase the line height of the card paragraph.

  0
• 

  Yarijey• 10

  @Yarijey

  Submitted 26 days ago

  

  Semantic HTML, responsive mobile first design, media query , Flex-grid

  1

  11

  

  P

  tagoras• 50

  @tagoras

  Posted 25 days ago

  I would suggest the following changes:

  1. Increase the font size of the QR component title. A neat little trick that I use is to set font-size: 10px at html root in your CSS file i.e. html {font-size: 10px). Then you can comfortably use rem units in your size calculations. 2)Reduce the margin between the QR picture and the heading!

  0