Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links profile

@Fatma-Tawfeek

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

  • organization of the code
  • using semantic HTML

What challenges did you encounter, and how did you overcome them?

  • make "ul" element take the 100% of the card using max-width
  • I used the width property instead of max-width

What specific areas of your project would you like help with?

  • adjust spaces between text and other elements

Community feedback

P
tagoras 50

@tagoras

Posted

I would suggest the following changes:

  1. Increase the overall size of the card, including font-size, margins and paddings. You can do this by setting html{font-size: 62.5%} and then setting the font-size to an appropriate amount in your card container using rem units. Same with margins and paddings.
  2. Decrease the margin between the person's title and the location.
  3. Increase margin of links, make the name of each social link bold (font-weight: bold or using an appropriate numerical amount).

Nice solution!

Marked as helpful

0

@Fatma-Tawfeek

Posted

@tagoras Thank you for your feedback! I'll definitely keep it in mind for next time.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord