Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
- organization of the code
- using semantic HTML
- make "ul" element take the 100% of the card using max-width
- I used the width property instead of max-width
- adjust spaces between text and other elements
Community feedback
- @tagorasPosted 2 months ago
I would suggest the following changes:
- Increase the overall size of the card, including font-size, margins and paddings. You can do this by setting html{font-size: 62.5%} and then setting the font-size to an appropriate amount in your card container using rem units. Same with margins and paddings.
- Decrease the margin between the person's title and the location.
- Increase margin of links, make the name of each social link bold (font-weight: bold or using an appropriate numerical amount).
Nice solution!
Marked as helpful0@Fatma-TawfeekPosted 2 months ago@tagoras Thank you for your feedback! I'll definitely keep it in mind for next time.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord