Skip to content
OverviewSolutions
25
Comments
5
Syazwan Fitri
@syzwnftr

All comments

  • Syazwan Fitri•400
    @syzwnftrPosted almost 3 years ago

    Hi there! Good job on this challenge. I see you have some accessibility issues, so this is my suggestion:

    1. You might want to change <div class = "container"> to <main class = "container"> since page should have one <main> tag
    2. Change <h2> to <h1>
    3. Wrap <div class="attribution"> with <footer>

    Hope these would fix the issues. Have a good day!

    Marked as helpful
    0
  • Sai Thi Han•20
    @SaiThihanSubmitted almost 3 years ago

    Any feedback or suggestions? I'll be happy to improve myself with your help

    QR-Code-Component

    1
    Syazwan Fitri•400
    @syzwnftrPosted almost 3 years ago

    Hi there! Good job on this challenge. I see you have some accessibility issues, so this is my suggestion:

    1. Change <section> to <main>
    2. Change <h2> to <h1>

    These should fix the issues. Have a good day!

    0
  • Syazwan Fitri•400
    @syzwnftrPosted about 3 years ago

    Hi Steven, as a first project I think this is good. But I noticed that it isn't responsive so maybe you can set max-width instead of width for main-box. Make sure to avoid using px because it is an absolute unit. For the accessibility issue, you can get rid of it by changing h2 to h1. I hope this will help.

    Marked as helpful
    1
  • Syazwan Fitri•400
    @syzwnftrPosted about 3 years ago

    Hi, I think this is good. For the accessibility issues, you can get rid of that by changing div tag that wrapped all the contents into main tag. That should fix the problem.

    0
  • Syazwan Fitri•400
    @syzwnftrPosted about 3 years ago

    Hey, this is good for your first project. I noticed there is an accessibility issues in the solution, which I also had it when I first submit mine. Here's what I'd suggest to get rid of these:

    1. Change the <div> right after <body> to <main>
    2. Change <h2> tag to <h1> tag
    3. Change the <div> before </body> to <section> or you can just put the <div> inside <main> tag.

    I hope this will help.

    Marked as helpful
    0