Skip to content
Submitted almost 3 years ago

QR code component using HTML and CSS

Achmad Riyadi•70
@AchmadRiyadi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first challenge, any feedback is welcome.

Community feedback

  • Syazwan Fitri•400
    @syzwnftrPosted almost 3 years ago

    Hi there! Good job on this challenge. I see you have some accessibility issues, so this is my suggestion:

    1. You might want to change <div class = "container"> to <main class = "container"> since page should have one <main> tag
    2. Change <h2> to <h1>
    3. Wrap <div class="attribution"> with <footer>

    Hope these would fix the issues. Have a good day!

    Marked as helpful
    0
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    Hey, looks like you fixed some of the accessibility issues already. You can just generate a new error report to update the numbers when you're done.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord