I used a jQuery for the making the page more interactive by changing the background colour of selected rating. Is that effective way to do it? I donot know much about jQuery and just learning it. Can it be done in more effective way? Does investing time in learning jQuery effective in long run? Are any alternatives used in real-world? Also, is my practice of using landmark tags effective? What are the changes can I make to optimize my code?
Swaraj
@swarajzzAll comments
- @KamanDShresthaSubmitted about 2 years ago@swarajzzPosted about 2 years ago
Hi @KamanDShrestha, great job completing your second challenge! I think this looks really good and works well; the only suggestions I have is to add a
cursor: pointer
for the rating buttons and submit button.And there is just one thing I'd suggest you fix, instead of having a default value for rating, you could disable the button until the user has picked a rating.
0 - @GeekkyCoderSubmitted about 2 years ago@swarajzzPosted about 2 years ago
Hi Faraz, great job completing on this challenge! I think this looks really good; the only suggestion I have is to work more on the responsiveness of the page, as from width: 500 to 1200 it is basically inaccessible and to set a height of 100% to the "desktop-image" class.
1 - @daft2Submitted about 2 years ago
I added my disabled state so it can't submit when the user haven't clicked a rating yet
@swarajzzPosted about 2 years agoHi Daft, great job completing your second challenge! I think this looks really good and works well; the only suggestion I have is to add a
transition
on the hover states for the rating buttons and submit button.0 - @agustinasegatSubmitted about 2 years ago@swarajzzPosted about 2 years ago
Hi Agustina, great job completing your first challenge! I think this looks really good and works well; the only suggestion I have is to add a cursor: pointer for the add to cart button and you can also play with font-sizes to make it look more visually pleasing.
0