All comments

• 

  Cephas190•10

  @Cephas190Submitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  I'm proud of my first project with FrontEnd mentor after completing an online self-paced bootcamp. It has provided me with the opportunity to put the diverse skills to practice, thus re-enforcing the knowledge I've been gaining. I have also learnt new concepts such as custom CSS variables and the tag in HTML. I've also learnt to deploy websites on github pages, which is really great for my future career.

  What challenges did you encounter, and how did you overcome them?

  Differentiating the colours to use was an uphill task. Making the page responsive has been a nightmare.

  What specific areas of your project would you like help with?

  The custom fonts in the CSS files do not reflect on the webpage. Please help to figure out why and how to solve it. I understand I can use in HTML, but that is not the approach I'd like to take this time. Making the page responsive has been a nightmare. I can't seem to get past the @media and screen () query. How do I add the background colour for desktop sit and move everything from the screen edge? a general review of my codes including best practices and readability would be highly appreciated

  

  Recipe-page-main

  2

  20
  

  P

  svetikbaihe•150

  @svetikbaihePosted about 2 months ago

  Hi there!

  First of all, congratulations on your first project here!

  Not an expert, just a toddler in front-end ;) I came across your project today and decided to share some thoughts, maybe you can use it for your next practice.

  As for your work overall, you handled it quite well. Great job!

  There are some aspects that might be changed. The first thing that caught my eye is HTML structure. I guess, it's one of the most important things that should be honed first among other things at the beginning of your path as a developer. Consider adding divs where necessary so you can easily style your elements. If you add a wrapper to your header and main section, you will be able to move your content away from the edges and add the needed background to your body. Another option instead of styling the body directly is to add another div and apply styles to it.

  Pay attention to design details such as the border-radius on images, margins, and paddings.

  Talking about responsiveness, mobile-first workflow is definitely worth looking into. It's easy to work with and helps you to scale your project from small devices to big ones.

  Regarding font sizes, I noticed you're using a comma instead of a semicolon, which can lead to a syntax error.

  Also, I recommend working with README and markdown from the start as well. It can be useful in your future career. It would be great if you replaced the default template of README with your own description of the project. And the last thing, comments and other notes should be removed from the project.

  Hope it will be useful for you. Good luck!

  0