@stephenkjohnston
@dev-rome
Submitted
What are you most proud of, and what would you do differently next time?
N/A
What challenges did you encounter, and how did you overcome them?
N/A
What specific areas of your project would you like help with?
N/A
@stephenkjohnston
Posted
Nice work! I liked the idea of using as few tags as necessary to build something. I also appreciate that you didn't go overboard with classes.
Marked as helpful
@MaxCodeCraft
Submitted
What are you most proud of, and what would you do differently next time?
This is my first responsive project, with more attention to the margins and paddings than the previous one ! I've really enjoyed this one as it was more complex and made me Google a thing or two so I learnt a lot with it.
What challenges did you encounter, and how did you overcome them?
Here is what I learned during this project:
What specific areas of your project would you like help with?
I didn't manage to have the left and right margins of 24px when viewed on mobile, if I did put margin: 0 1.5rem, i had the margin on the left side only and the right side was cropped, any ideas ? Thank you
@stephenkjohnston
Posted
Hello @MaxCodeCraft, You did a great job matching the design and your code looks great. Keep up the good work!
I do have a couple suggestions:
<time> MDN Article. The only real benefit to this is it can improve accessibility for impaired users.@MdIrfan-ul
Submitted
What are you most proud of, and what would you do differently next time?
I Finished this project i somehow stuck at placing the image at center and i googled and find out the approach
What challenges did you encounter, and how did you overcome them?
the responsiveness for mobile and placing the image at the center which takes me 2 hrs to fix it
What specific areas of your project would you like help with?
About the Styling I made and the responsiveness please review my code and tell the area I should work on improving that and also give me an approach for that.
@stephenkjohnston
Posted
Hi @MdIrfan-ul,
Nice work on this challenge. The structure of your code looks good! I like that you added an alt tag for the QR code. It's also great that you used CSS variables.
I have a couple of suggestions for you on a couple things that may improve it:
