Gideon Olumide Dada• 240
@Olumide2596
Submitted
Hi, any feedback on how to improve will be appreciated. Thank you😁
Stefan Wright
@stefanwright1988
All comments
- Stefan Wright• 80
@stefanwright1988
Posted
Hey,
One thing that to me causes confusion is that on a mobile the text shows up as
IMMERSIV E EXPERIEN CES THAT DELIVER
(hoping that formats correctly), I'd suggest looking at making the font a bit more responsive. EDIT: I don't think it's formatted in the comment correctly but there is a line break between V and E and then N and CES
I haven't been able to review on a desktop right now. The code looks OK, one thing I notice is the navigation where you have 2 repeatin blocks one for mobile nav and one for desktop, in a larger environment this could cause confusion you should be able solve this behaviour using CSS and media queries
Marked as helpful
1 - Nikhil Shinde• 30
@Nikshinde7
Submitted
- I have included the image for the Graphs sections, as I was unaware of which library to use there, Feel free to include your comments about which graph library I should Use!!
Thanks!
Stefan Wright• 80@stefanwright1988
Posted
Hey,
I suggest you revisit this task, the graph should be generated from the JSON file provided and not a static image, it should also have a hover effect to show the value for that day.
Also your site is not responsive, when viewing on a mobile device everything overflows its container, and your graph (which again should not be an image) is not viewable.
There is not much use of semantic HTML elements in use, I would suggest reading up on those
Marked as helpful
0
