P
kassahunAmdie• 70
@kassahunAmdie
Submitted
Петро
@stadnik-petro
All comments
- Петро• 50
@stadnik-petro
Posted
Great work, the only thing to fix is the distance between the photo and the name))
1 - Nguyễn Trường An• 60
@ntan2k3
Submitted
Петро• 50@stadnik-petro
Posted
Great job done! There is one caveat you have in the text different height from the original is a fashionable fix adding the value "line-height"
Marked as helpful
1 - Ehsan• 210
@Ehsan-eslami
Submitted
This is the Advice-generator-app challenge from Front-end mentor challenges. This app doesn't work on Firefox. I don't know why, but I thought it would be better to mention this problem.
I would appreciate it if you could tell me how to make the code better.
Петро• 50@stadnik-petro
Posted
Hello!
It seems like there might be some issues with Firefox due to the click handler being invoked before registering in addEventListener(). Here's how you can fix it:
adviceBtn.addEventListener("click", getAdvice); getAdvice();Another aspect I want to draw your attention to is handling clicks on the
imgtag instead of<div class="dice-img">. This may lead to a situation where the user isn't clicking directly on the image, and the code won't work. I recommend paying attention to this point!0
