Skip to content
OverviewSolutions
3
Comments
4
Петро
@stadnik-petro

All comments

  • Петро•50
    @stadnik-petroPosted 4 months ago

    Great work, the only thing to fix is the distance between the photo and the name))

    1
  • Dipesh•430
    @Dipesh-sapkota1Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Any suggestion to improve would be appreciated

    responsive blog-preview-card-main

    1
    Петро•50
    @stadnik-petroPosted 4 months ago

    Чудова робота

    0
  • Петро•50
    @stadnik-petroPosted 4 months ago

    Great job done! There is one caveat you have in the text different height from the original is a fashionable fix adding the value "line-height"

    Marked as helpful
    1
  • Ehsan•210
    @Ehsan-eslamiSubmitted 10 months ago

    This is the Advice-generator-app challenge from Front-end mentor challenges. This app doesn't work on Firefox. I don't know why, but I thought it would be better to mention this problem.

    I would appreciate it if you could tell me how to make the code better.

    advice generator app main

    1
    Петро•50
    @stadnik-petroPosted 10 months ago

    Hello!

    It seems like there might be some issues with Firefox due to the click handler being invoked before registering in addEventListener(). Here's how you can fix it:

    
adviceBtn.addEventListener("click", getAdvice);
getAdvice();

    Another aspect I want to draw your attention to is handling clicks on the img tag instead of <div class="dice-img">. This may lead to a situation where the user isn't clicking directly on the image, and the code won't work. I recommend paying attention to this point!

    0