QR code component

Community feedback

• 

  Петро•50

  @stadnik-petroPosted 5 months ago

  Great job done! There is one caveat you have in the text different height from the original is a fashionable fix adding the value "line-height"

  Marked as helpful

  1
• 

  T

  Grace•31,270

  @grace-snowPosted 5 months ago

  Well done on completing your first challenge.

  I give feedback on this a lot and it’s almost always the same things as this is the challenge to lay down important foundations.

  So rather than repeat myself I’m going to point you to read others feedback I’ve left on this challenge.

  For example, see my comments on these solutions and use those learnings to refactor yours:

  • https://www.frontendmentor.io/solutions/qr-component-using-padding-and-border-radius-with-a-bit-of-font-css-IrBrFHDvWs
  • https://www.frontendmentor.io/solutions/responsive-barcode-page-using-css-media-query-and-grid-to-solve-it-all-Y-N1UTiLQi
  • https://www.frontendmentor.io/solutions/finished-qr-code-component-_AM0tpAazt
  • https://www.frontendmentor.io/solutions/qr-code-component-3ai6h6v_Xw

  Once you've fixed this one, go through your others and fix those too. And I need to stress -- Don't rush through lots of challenges before getting or at least reading others' feedback on the challenge and then improving what you've done using that feedback. All rushing through will do is repeat mistakes over and over, which then will be very hard work to go back and fix on so many. It's the feedback where you will get the value from this platform.

  Marked as helpful

  0