Skip to content
OverviewSolutions
3
Comments
3
Sridarshan
@sridarshan-webjava

All comments

  • Sridarshan•60
    @sridarshan-webjavaPosted over 2 years ago

    Amazing work and congratulations for completing the challenge!

    Using min-width or max-width for media queries depends on how you approach the solution. If you go for a mobile-first approach then you might probably use min-width. Else you might use max-width.

    Also in your solution, the container seems to be overflowing in small screen sizes. Do ensure that the container is responsive in smaller screen sizes as well

    Happy coding!

    Marked as helpful
    0
  • Sridarshan•60
    @sridarshan-webjavaPosted over 2 years ago

    Your site is not available for viewing. Do check out the deploy logs on netlify to verify whether the code was successfully deployed or not.

    Cheers

    0
  • Abdelghafour•580
    @Abdelghafour122Submitted over 2 years ago

    I added a simple generator to this challenge because it felt too simple.

    This also was the first time i use Material UI

    If you guys have any suggestions on how i can improve my code, please let me know. Thank you!

    Qr code component using React.js and MUI

    2
    Sridarshan•60
    @sridarshan-webjavaPosted over 2 years ago

    Just my perception. You can have the modal shown first to generate a QR code. When nothing is entered, the default QR design can be displayed thereafter hiding the modal. If something is entered, the corresponding QR code can be attached. An icon can be used to toggle back to the modal screen to edit the link or text.

    But it was a great thought on using a QR generator to enhance the application. Kudos and Happy coding👍

    1