Skip to content
Submitted over 2 years ago

Qr code component using React.js and MUI

Abdelghafour•580
@Abdelghafour122
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I added a simple generator to this challenge because it felt too simple.

This also was the first time i use Material UI

If you guys have any suggestions on how i can improve my code, please let me know. Thank you!

Community feedback

  • Sridarshan•60
    @sridarshan-webjavaPosted over 2 years ago

    Just my perception. You can have the modal shown first to generate a QR code. When nothing is entered, the default QR design can be displayed thereafter hiding the modal. If something is entered, the corresponding QR code can be attached. An icon can be used to toggle back to the modal screen to edit the link or text.

    But it was a great thought on using a QR generator to enhance the application. Kudos and Happy coding👍

    1
  • Shashree Samuel•9,260
    @shashreesamuelPosted over 2 years ago

    Hey good job completing this challenge. Keep up the good work

    Your solution looks great however I think that your card is missing a subtle box-shadow using box-shadow.

    I hope this helps

    Cheers Happy coding 👍

    1
    Abdelghafour•580
    @Abdelghafour122Posted over 2 years ago

    @TheCoderGuru i totally forgot about it, thanks for pointing that out!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord