This is my first project on Frontend Mentor. Could you please provide me some feedback on the work I have done. Tkank you.
Aayush Sood
@soodaayushAll comments
- @yanaantonnaSubmitted over 3 years ago@soodaayushPosted over 3 years ago
Maybe fix the accessibility and HTML issues. Your font on the buttons does not look right compared to the design photo.
That's all I have to say.
Happy Coding!
0 - @abhik-bSubmitted almost 4 years ago
Hi Frontend Mentors π,
I created some staggering animations using
setTimeout
s , however I personally feel there's a better a way for that. So if anyone knows that please help me out!Any feedbacks,tips,suggestions will be highly appreciated π
@soodaayushPosted almost 4 years agoYou might want to add media queries for the input and button because on bigger screens, the input and button are starched.
Otherwise you did great!
Happy coding!
Marked as helpful1 - @UofMBobSubmitted almost 4 years ago@soodaayushPosted almost 4 years ago
I can't preview your website so fix that and the HTML and accessibility issues.
Let me know when you fixed the problem!
0 - @JonathanCierpSubmitted almost 4 years ago
Please let me know if there is something wrong or if we can do it in a better way π
@soodaayushPosted almost 4 years agoYour website is very good! I do suggest fixing the HTML issues.
Happy Coding!
1 - @m-boychukSubmitted almost 4 years ago@soodaayushPosted almost 4 years ago
Your website is good but there are some things that I suggest you improve on.
-
You forgot to add colors on some of the buttons. They weren't supposed to be the color when hovering over it. They were supposed to be that color for display
-
On bigger screens, the image below the header will fall out of it's box
-
The logo on the footer isn't the same compared to the design. What you should do is copy the original logo and make another one for the footer. When you Look in the svg file, there should be multiple instances with the word fill. In that box, your supposed to make the color white.
-
The copyright at the footer should be below all of the content
That's all I have to say!
Happy Coding!
0 -
- @StephenBuleySubmitted almost 4 years ago
Mostly responsive, I know this isn't a huge page.
Can't for the life of me figure out the two background images to look like the design, other than that just general tips and fixes to help make my code more readable/efficient! Thanks!
@soodaayushPosted almost 4 years agoThe way to position those 2 background images were to say background-position: top right, bottom left;
Happy Coding!
0 - @SoloLereSubmitted almost 4 years ago
Your feedback and suggestions are highly appreciated!
@soodaayushPosted almost 4 years agoYour website is very good but I suggest fixing the accessibility and HTML issues.
That's all I have to say!
Happy Coding!
0 - @DelconerSubmitted almost 4 years ago@soodaayushPosted almost 4 years ago
Your website is very good! I see no issues at all!
1 - @mohamed1maghraby-divSubmitted almost 4 years ago
please leave your feedback
@soodaayushPosted almost 4 years agoYour website is great! There is some minor issues that I suggest fixing.
-
The "Verified Graduate" font size is a bit bigger than the design
-
The paragraphs need to have some opacity
That's all I have to say!
Happy Coding!
1 -
- @DebbyyySubmitted almost 4 years ago
Feedback is required. Ways to improve is also very important. Thank you!
@soodaayushPosted almost 4 years agothere are some problems when viewing this on bigger screens. This is coming from someone who uses a 4K monitor.
-
Some images are very big
-
the background image at the very top doesn't take up the whole width. The way to fix this is background-size: contain;
-
Some of the gaps are way too much. I suggest toning it down.
-
Some widths of the images are kind of short
Otherwise your website is good!
Happy Coding!
0 -
- @Karimsamir112Submitted almost 4 years ago
hey , Is this good ?? and what is the mistakes I did ?
I care so much about feedback because it let me improving myself
Thanks in advanceΨ²
@soodaayushPosted almost 4 years agoyour website is decent but there are some things I suggest you improve on.
-
Fix all of the HTML and Accessibility issues. If you press view report, you will see all the issues in your code.
-
You should probably use the pictures that they have given you in the files.
-
The boxes have barely any spacing so I suggest adding padding to those boxes.
-
The alignment of the boxes is kind of broken so I suggest making all heights of the boxes equal.
-
There are also some weird line breaks in all of the paragraphs so I suggest adding more spaces to the boxes.
-
Your content isn't centered so I suggest using CSS Flexbox to center the content.
That's all I have to say!
Happy Coding!
0 -
- @macrespo42Submitted almost 4 years ago
I'm a total newbie in front end dev, so if you have any suggestions to get a cleaner html/css I will be very happy π thanks guys π
@soodaayushPosted almost 4 years agoYour website is great! I suggest fixing your HTML issues.
Happy Coding!
1