Skip to content
OverviewSolutions
15
Comments
3
Soe Wai Yan Aung
@soewaiyanag

All comments

  • Soe Wai Yan Aung•410
    @soewaiyanagPosted over 2 years ago

    Great job with functionality. But with design, I found that the dice button is not fully centered. When I check your code I found that you are using a fixed value for the right property which is right: 8rem. You can fix it by setting it's right to 50% and adding transform: translateX(-50%). It will center the dice no matter what size or width of the card. And give it border-radius 50% to get a full circle. And would be better if you fix your font size and font-weight. Other than that, well done with functionality, keep it up.

    Marked as helpful
    0
  • PhoenixDev22•16,950
    @PhoenixDev22Submitted almost 3 years ago

    Hi everyone, had a challenging time with this one from start to finish.

    My struggles, and bugs:

    • toggle menu icon javascript only works on the second and subsequent clicks. not on the first .Any suggestions?
    • I just noticed that the next and previous buttons are not working on the live solution while they are working on the live server, I've tried so many times .no idea how this bug did occur?

    I don’t know for sure if the images fit the screen . Please let me know if you find any overflow or other quirks with the images.

    I'm still learning about accessibility .

    In javascript , I used more basics ways.

    Please share your thoughts! Had a great time working on the CSS, the image grid was a new challenge for me. There’s still some more to do like the readme, cleaning up repeating code, and html warnings.

    I'd appreciate any comments for improvements or anything I've missed. Thank you!

    Frontend-Mentor-E-commerce-product-page HTML CSS JS

    4
    Soe Wai Yan Aung•410
    @soewaiyanagPosted almost 3 years ago

    So you want to change fill on hover right? I solve it by creating SVG as a react component. Here is my submitting. But you can solve it with pure CSS too. If you are using vs-code copy the codes inside SVG. And paste it in HTML and treat it as an HTML element. Give it a className and also remove its inline fill attribute(must remove otherwise CSS won't work). Now you can modify fill with CSS.

    Marked as helpful
    0
  • Soe Wai Yan Aung•410
    @soewaiyanagPosted almost 3 years ago

    Nice work the solution is as perfect as the original design. And try to fix those ACCESSIBILITY ISSUES and HTML ISSUES as much as you can.

    Marked as helpful
    0