Skip to content
OverviewSolutions
9
Comments
10
Sergiu
@smalancea

All comments

  • Sergiu•250
    @smalanceaPosted 11 months ago

    I think your solution is a little bit different than the original one. Have you tried starting with the basic main containers and working your way to the smaller components? The font size is also different and the font weight too. I think overall looks good but you just need organize it a little better.

    Marked as helpful
    0
  • Louai Khodary•350
    @LouaiKhodary13Submitted 12 months ago

    I felt like a rebel, so I added animation fade in on the initial status and when displaying the thank-you note as well if there are any notes on how I could've done this challenge differently, don't hesitate to share your thoughts. Happy Coding

    Interactive rating component

    1
    Sergiu•250
    @smalanceaPosted 12 months ago

    I like the design but it is very different than the original one, try to focus on small details. I also took a look through your files on GitHub. Your JS needs a little bit of cleaning and organizing, try to simplify it.

    Marked as helpful
    0
  • Sergiu•250
    @smalanceaPosted 12 months ago

    Your design is slightly different from the original. Colors, font-size, font-weight, padding and etc need to be adjusted. I took a look through your files on github and I could say that you need to rearrange the order of those files and folders. Html is good and CSS too, however I would say that you will need to get better and naming classes in a more understandable way and writing css properties in order. Overall looks good.

    1
  • Sergiu•250
    @smalanceaPosted 12 months ago

    Design is pretty good and mobile version too. I took a look through your files and I like that you commented your CSS and have properties in order. However, you could simplify your JS by not repeating code. Also HTML needs some commenting too.

    Marked as helpful
    0
  • Sergiu•250
    @smalanceaPosted 12 months ago

    The design looks somewhat close to the original one but there's some little differences like the font-weight and the border for the button.

    I looked through your html and css and could say something: You need to clean index.html a little bit by having better classes and commenting code. Your CSS could also be a little bit cleaner by putting classes in order and properties too. Overall looks good.

    Marked as helpful
    0
  • Corey•20
    @acoreyuSubmitted 12 months ago

    This was a good challenge for my current skill level. It took me a while to get the CSS where it needed to be but it all worked out. I always appreciate any helpful feedback anyone may have on best practicese or if you find any bugs with my code. Thanks!

    Responsive Landing Page using Flex box. Base Apparel Page

    1
    Sergiu•250
    @smalanceaPosted 12 months ago

    Your code looks very clean. I took a look through your files and I would say good job for commenting. The design is very clean and also the mobile version looks good.

    Marked as helpful
    0
  • Sergiu•250
    @smalanceaPosted 12 months ago

    Let me know if my code is clean and functional

    0
  • Sergiu•250
    @smalanceaPosted 12 months ago

    Not gonna lie, the design looks very good and almost 1/1 with the original design.

    Your HTML could be a little bit cleaner by separating CSS and JS in different files and linking them with index.html.

    Marked as helpful
    1
  • Namrata Sinha•530
    @nmrtsnhSubmitted 12 months ago

    Hello everyone,

    I am Namrata and this is my solution for the Interactive rating component challenge

    If you have any suggestions to improve my code, please feel free to share!

    Thank you 🙏

    Interactive rating component

    1
    Sergiu•250
    @smalanceaPosted 12 months ago

    I like that you tried to include a nice subtle linear gradient which looks pretty good. You could've used a little more border radius on the corners to mach the original design and also a little bit more top and bottom padding for the button. I can't see the project on github pages, I wanted to see how the mobile version looks.

    Marked as helpful
    0
  • Sergiu•250
    @smalanceaPosted 12 months ago

    Overall the design looks good, but you could've made it a little bit closer to the actual size. The button also has a subtle box shadow in the original design but yours doesn't.

    0