All comments

• 

  Danrare•70

  @danrareSubmitted over 2 years ago

  I had it difficult getting my js codes to work the way it should. But against all odds I prevailed. Maybe for now I will be focusing on writing clean js codes.

  

  Responsive layout using flexbox

  1

  30
  

  Skippy•110

  @skippysworldPosted over 2 years ago

  It looks well overall. I can spot few misalignments in CSS but the logic behind rating seems to work well.

  By inspecting your code quickly..:

  1. You can improve your HTML accessibility using landmarks - such as <main> for main content of the webpage.

  2. IMG tags should include width and height attributes that matches source image ratio. When using decorative images such as icons that are not necessary for the rest of the content, you can embed them using CSS.

  3. It's better to put script src tag at the end of your HTML file (before </body> tag). That way the HTML will get loaded properly first before loading JS interaction to it.

  4. var statement is considered obsolete and should not be used for new designs anymore. let and const are it's successor, lookup MDN site for more information about them.

  You can look up my solution I made yesterday for this challenge, maybe it will inspire you :)

  Enjoy and keep it up!

  1

  This comment has received 3 repliesShow
• 

  P

  Layne Taylor•140

  @laynetSubmitted over 2 years ago

  Would love any feedback, especially about react and organization!!

  

  Interactive rating component using ReactJs, JSX, HTML and Sass

  1

  20
  

  Skippy•110

  @skippysworldPosted over 2 years ago

  Not sure about those frameworks as far as I don't know them - therefore cannot advise how to improve CSS (because I don't know how Sass works)..

  Neverthless - rating component on thanks page does not show what user picks. Try to improve the logic behind it :)

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Miguel Córdoba Rojas•10

  @MiwuanSubmitted over 2 years ago

  ¿How to make it responsive so that each column stack on eachother vertically?

  

  Evaluación Formativa 1

  3

  40
  

  Skippy•110

  @skippysworldPosted over 2 years ago

  If you're beginner, I'd recommend write your CSS by yourself instead of using Bootstrap. I mean there's nothing bad about frameworks, but I would personally prefer to learn how to write CSS by myself before moving on Bootstrap - when you know how things works, you may better understand Bootstrap itself and use their Docs far more efficient.

  0