@sedaryildirim
Submitted
@simon7195
@sedaryildirim
Submitted
@simon7195
Posted
Perfect job! Closer to the original design as mine.
@ameera-abed-aldin
Submitted
@simon7195
Posted
Looks perfect to me. Good job!
@Ay-dotcode
Submitted
@simon7195
Posted
Nice job!
@japaxapa
Submitted
What are you most proud of, and what would you do differently next time?
I started the code with mobile first in mind and used BEM to organize the code
What challenges did you encounter, and how did you overcome them?
Styling list tags and setting the responsive code
What specific areas of your project would you like help with?
Any feedback on BEM usage
@simon7195
Posted
Well done!
@randyrobson
Submitted
@simon7195
Posted
Hi! π
Your solution is really nice, I really like the little animation that moves when the buttons are hovered.
May I make a few comments :
div
to insert your image. I think using an img
tag would have been more appropriate, especially in terms of accessibility, as in your case you can't display alternative text (alt="avatar of ..."
).p
tag would have been more appropriate than an h2
.section
tags defines important areas of a site. In the case of a linktree, a div
or span
would have been more appropriate.I hope you find my comment useful. Keep it up! βοΈ
@Satyam-Pandey677
Submitted
What are you most proud of, and what would you do differently next time?
Now I'm understand the html trees and all CSS properties
What challenges did you encounter, and how did you overcome them?
None
What specific areas of your project would you like help with?
none
@simon7195
Posted
Hi there! I think you've got the wrong project. This is the QR code project.. π You should replace the link if possible, it's a shame not to be able to see your solution and give you advice if needed.
@Kendotcom
Submitted
@simon7195
Posted
Hi! It's not bad at all, the code is clean and the CSS is commented. The card is responsive and the font sizes in em
which is good. You could do this to improve :
I'm not a pro, so take my advice with a grain of salt! Good Job!
rem
instead of em
so that the fonts react to the user's settings.<h1>
instead of <h2>
to comply with the HTML agreement.<main>
tag like this <body><main>..content-here..</main></body>
, again it's to better comply with the HTML agreement.Good luck!
Marked as helpful