Simon Capillon• 100
@simon7195
Posted
Hi! It's not bad at all, the code is clean and the CSS is commented. The card is responsive and the font sizes in em which is good. You could do this to improve :
I'm not a pro, so take my advice with a grain of salt! Good Job!
- Use
reminstead ofemso that the fonts react to the user's settings. - Use
<h1>instead of<h2>to comply with the HTML agreement. - Put everything in a
<main>tag like this<body><main>..content-here..</main></body>, again it's to better comply with the HTML agreement. - There are a few differences between the dimensions of the solutions and the original design (lengths, heights, border-radius). On Figma, you can control a specific element with CTRL (or CMD) key + LEFT MOUSE CLICK on it and view its characteristics in the right-hand panel (to check border-radius, for example). You can also check spacing by holding the ALT key + MOUSE OVER a selected element.
Good luck!
Marked as helpful
0
