Skip to content
OverviewSolutions
10
Comments
10
P
shpokas-io
@shpokas-io

All comments

  • Ian Parker•200
    @i-prkrSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud that I was able to use CSS in a new way, using it for the filtering of the page. CSS attributes wasn't something I'd worked with before and found it to be a nice solution.

    What challenges did you encounter, and how did you overcome them?

    The main challenge I had was in wanting to build out the cards dynamically while reading from the data.json file, as if I was using a component based framework without using one. I tried to spend a bit of time planning out how I was going to structure everything and wrote it out as html to refer to when writing the javascript. I'm hoping the javascript is clear enough as concise as it can be.

    I also built out a working skeleton for the dynamic tile creating, layout and filtering, and this helped me a great deal. Most of the work from there was rewriting it to fit with BEM.

    What specific areas of your project would you like help with?

    Things in particular for feedback that would be greatly appreciated:

    1. Any feedback on the usage of BEM, I'm still familiarising with it and wanting to make sure I am implementing it using best practise
    2. Any feedback on the javascript - how it might be cleaner / more reusable
    3. Any missing accessibility features?

    Time tracking dashboard (Sass, CSS filtering)

    1
    shpokas-io•150
    @shpokas-ioPosted about 2 months ago

    Great job , as i only see that you can try make it more pixel perfect, other than that cool !

    0
  • Alejandro Rodriguez•110
    @AlejandroTypesSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    Manage to finish, probably how I handle managing the phone size part

    What challenges did you encounter, and how did you overcome them?

    My major challenge was making the email input button to look exactly like the error img shown in the test. I procrastinated on this test because of it. But I managed to finish it.

    What specific areas of your project would you like help with?

    Is this how you handle media query and how to adjust it for mobile devices? any better ways to code my "Valid email required" with just basic js,css?

    Newsletter Signup Page

    2
    shpokas-io•150
    @shpokas-ioPosted about 2 months ago

    Beutifull code, i like that you add comments near JavaScript to figure out faster what your code does , only you can add live URL to your solution in GitHub repo

    0
  • shpokas-io•150
    @shpokas-ioPosted 2 months ago

    Good job, i see that this challange is hard not only for me :D Keep pushing it. From what you can change is use background color on body element since now you color only div container. Anyweays good job and good luck with challenges ahead

    1
  • shpokas-io•150
    @shpokas-ioPosted 2 months ago

    Great job, keep up with the speed

    Marked as helpful
    0
  • shpokas-io•150
    @shpokas-ioPosted 3 months ago

    Cool, i would only made when using mobile, text-align-center, top text

    0
  • shpokas-io•150
    @shpokas-ioPosted 3 months ago

    Great job, nice work on responsive design

    0
  • shpokas-io•150
    @shpokas-ioPosted 3 months ago

    Great job

    0
  • shpokas-io•150
    @shpokas-ioPosted 3 months ago

    Cool it is one:one nice joob, keep up the good work, also you can try and shorten your description of GITHUB. Goodluck with learning, you got this

    0
  • Danylo Shlapak•60
    @Born2FlexSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    I've done it quickly

    What challenges did you encounter, and how did you overcome them?

    revised events

    Blog preview

    1
    shpokas-io•150
    @shpokas-ioPosted 3 months ago

    Delete unused files inside your GitHub. Try to type only info you actually did or need in README.md doc. Project it self looks nice and 1v1 the real one, good job <3

    0
  • shpokas-io•150
    @shpokas-ioPosted 3 months ago

    I am not a professional, but it is nice try on adding new elements and look at this design

    1