Skip to content
OverviewSolutions
4
Comments
4
sergicente
@sergicente

All comments

  • sergicente•80
    @sergicentePosted 4 months ago

    Nice work there, i just can tell you that adding some line-height and some margin on top and bottom of the container it would be more similar to the requested design, the rest is pretty identical, congrats.

    0
  • RachelAbit•80
    @RachelAbitSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud that I can at least use my fundamental knowledge of CSS. Next time, I will add the CSS Framework to fully optimize my knowledge about designing.

    What challenges did you encounter, and how did you overcome them?

    Because I was unsure about the value to enter, I had difficulty in using min(). I finally overcome it by estimating the proper value.

    Responsive Social links

    2
    sergicente•80
    @sergicentePosted 4 months ago

    Nice result, I like the new style of the website.

    I see a little inconsistency about the position of the container inside the webpage. you fix the height of the body in 100vh, thats great, but after that you add a margin-top in the container of a 9%, so it results in a webpage height of 109vh with an totally unnecesary scroll.

    What I recommend:

    *{ margin: 0; padding: 0; }

    body{ height: 100vh; display: flex; flex-direction: column; align-items: center; justify-content: center; }

    That will result in a full page with the div centered in the middle, with no scrolls, check mine if u want: https://sergicente.github.io/social-links-profile/

    Hope that helps!

    Marked as helpful
    0
  • sergicente•80
    @sergicentePosted 4 months ago

    Nice result Andrew!!! It looks pretty identical. I will give you a tip, instead of using margin-top in each item inside the main container, you can try to assign "display:flex" to the main container and "gap: 20px" to separate each item inside of it, it's more elegant :)

    Marked as helpful
    1
  • sergicente•80
    @sergicentePosted 4 months ago

    Bad preview link to your solution, maybe you would like to fix it.

    0