Responsive Social links

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 4 months ago

  Hey there! 🙋🏽‍♂️

  Congrats on completing the challenge! ✅

  Your project looks fantastic!

  Here's a tip to make it even better:

  Using margin and/or padding isn't always the best way to center an element. Try this super efficient method to center an element vertically and horizontally:

  📌 Apply this CSS to the body (skip position or margins to make it work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  Hope this helps!

  Keep up the great work!

  Marked as helpful

  0
• 

  sergicente•80

  @sergicentePosted 4 months ago

  Nice result, I like the new style of the website.

  I see a little inconsistency about the position of the container inside the webpage. you fix the height of the body in 100vh, thats great, but after that you add a margin-top in the container of a 9%, so it results in a webpage height of 109vh with an totally unnecesary scroll.

  What I recommend:

  *{ margin: 0; padding: 0; }

  body{ height: 100vh; display: flex; flex-direction: column; align-items: center; justify-content: center; }

  That will result in a full page with the div centered in the middle, with no scrolls, check mine if u want: https://sergicente.github.io/social-links-profile/

  Hope that helps!

  Marked as helpful

  0