All comments

• 

  Carlos Ortiz•50

  @Karlof99Submitted almost 3 years ago

  I am sure the code can be improved. What could make it shorter and cleaner?

  

  QR code component using HTML and CSS with Flexbox

  2

  90
  

  sanket kumar•300

  @sanketcharanpahadiPosted almost 3 years ago

  1. Always wrap your main content inside the <main></main> tag like this

  <main><img src="image-qr-code.png" alt="QR code" width="250" height="250"> <p class="p1"><b>Improve your front-end <br> skills by building projects</b></p> <p class="p2">Scan the QR code to visit Frontend <br> Mentor and take your coding skills to <br> the next level</p> </main>

  2.don't use inline styles as you have done in the <img> element 3. use relative widths and max-width property. 4. set the font family inside the body element .

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Radu Chiorean•100

  @chioreanradudandanSubmitted almost 3 years ago

  I'm not sure why my font family doesn't work as expected. Any feedback is appreciated. ✌🏻

  

  QR code component

  4

  60
  

  sanket kumar•300

  @sanketcharanpahadiPosted almost 3 years ago

  Your font family is not working because you have put "."(dot)html in the style.css file , remove the dot so that the html is considered as an element not as a class.

  2

  This comment has received 1 replyShow
• 

  sanket kumar•300

  @sanketcharanpahadiSubmitted almost 3 years ago

  Hello everyone, I have a doubt that the img element is inline but I can set my width and height . Can anyone help me out because we cannot set width to inline elements . so what is wrong here ?

  

  Responsive qr code component using mobile first workflow

  4

  70
  

  sanket kumar•300

  @sanketcharanpahadiPosted almost 3 years ago

  Thank you for resolving my issue.

  0