Carina• 150
@cfcmeireles
Submitted
sambuka-a
@sambuka-a
All comments
- sambuka-a• 420
@sambuka-a
Posted
Nice solution If you don't mind I would suggest to fix a form validation logic. For instance if visitor will leave any required input empty it will trigger an error, which is ok. However if visitor will go back and fill this input it won't clear/hide the error message.
1 - Seif-Sameh• 100
@Seif-Sameh
Submitted
sambuka-a• 420@sambuka-a
Posted
Nice solution. If you don't mind, I would suggest to work on styling and a shortens logic. For instance link validation (currently visitor can shorten not valid link and will get "undefined") and would be also nice to clear an input on "shorten It" click
Marked as helpful
0 - Alexander Hergert• 710
@alexander-hergert
Submitted
This is my solution for the Multistep form. I have used React to create it. To manage the state and the error handling and validation I have used the context and React Hook Form. This is also the first project I have used Typescript to manage the component props and form types. Working with the React Hook Form and using Typescript the first time was the toughest part for me. The styling was made with a mix of Styled Components and TailwindCSS. The form also submits you data to an API but does not save it there. Do not worry. Its just an API to simulate the POST request.
sambuka-a• 420@sambuka-a
Posted
Nice and clear solution, congrats A tiny suggestions if you don't mind:
- don't think cursor pointer is needed on form fields hover;
- phone number mask is a bit misleading because it wont pass validation;
- same title and description for all 4 steps;
Marked as helpful
1 - Alexander Hergert• 710
@alexander-hergert
Submitted
This was a funny project. Probably some refactoring would not harm the project and will be a goal in the future. I have tried to make the project a bit like the comments section on youtube or similar websites. I have tried to practise a bit useReducer and context API. My feeling is that the code feels overcomplicated still but thats going to be a target in the next future to simplify it more. For now it feels good but some critical bugs will be fixed as soon as encountered :) Feel free to check it out. You can switch users on top to simulate another log in. If you leave the comments empty then you will send a random quote. Here I had already some funny conversations lol. Make sure to expand the comment if you want to check a reply. They are closed by default.
sambuka-a• 420@sambuka-a
Posted
thanks for the reply.Now I got it) Interesting approach. It would work even better with thumbs up/thumbs down. Honestly I didn't notice + and - active (blue) state, that is why it was a bit confusing. It is a really good idea to allow only one single reaction per active user. Don't have it in my solution. I did my reaction logic something similar to stackoverflow (negative score allowed + posts are sorted depending on score). But I should also really add user vote limitation per post/comment. Good luck in your WebDev journey
1 - Alexander Hergert• 710
@alexander-hergert
Submitted
This was a funny project. Probably some refactoring would not harm the project and will be a goal in the future. I have tried to make the project a bit like the comments section on youtube or similar websites. I have tried to practise a bit useReducer and context API. My feeling is that the code feels overcomplicated still but thats going to be a target in the next future to simplify it more. For now it feels good but some critical bugs will be fixed as soon as encountered :) Feel free to check it out. You can switch users on top to simulate another log in. If you leave the comments empty then you will send a random quote. Here I had already some funny conversations lol. Make sure to expand the comment if you want to check a reply. They are closed by default.
sambuka-a• 420@sambuka-a
Posted
Nice solution. Bzw, seems like post score logic doesn't work properly. In case you would like to play around fixing it
0 - Plamen Dochev• 90
@PDochev
Submitted
sambuka-a• 420@sambuka-a
Posted
Hi Nice solution. I would suggest that you work on loading and errors handling
0 - Rabia Ismail• 130
@Rabiaismail21
Submitted
sambuka-a• 420@sambuka-a
Posted
Hi Nice solution. I would suggest that you work on loading and errors handling
Marked as helpful
0
