@cyrusyamirSubmitted almost 3 years ago
Md. Saadman Galib Rabbi
@saadman-galibAll comments
- @saadman-galibPosted almost 3 years ago
Your design is quite good but something could be better than the previous one. Your QR card is not perfectly centered vertically and you can use the hover effect in the image.
0 - @Suraj0500Submitted almost 3 years ago@saadman-galibPosted almost 3 years ago
The design is exactly the same. Try to add CSS for the footer also and then it will look better.
0 - @rico260104Submitted about 3 years ago
with this challenge makes my skills increase. i'm from indonesia
@saadman-galibPosted about 3 years agoAwesome design but try to make the border radius more. Then the project will look like more awesome
0 - @dwhensonSubmitted about 3 years ago
This one tripped me up in places I didn't expect. Notably, pseudo elements and SVGs. I put some details of the specific issues in the readme.
Key problems are:
- Horizontal scrolling is still an issue because of the first pseudo element. I am not sure how I can fix this, or why it is only happening on the first pseudo element and not the second. They are essentially the same element with some extra transitions on the second one. Any advice on this would be appreciated.
- I wanted to inline the SVG images but it caused so many issues that I opted not to in the end, and although not ideal took the performance hit. I had problems with background color, sizing and strange things in Safari - like bits of the SVG missing. Any suggestions on resources, courses or learning materials would be really appreciated.
@saadman-galibPosted about 3 years agoThe project you have done is awesome.
0
