@rui-rmv
@ssantos-lucas
Submitted
Hello, everyone.
I have one doubt, i hope someone can help me with that.
If you look at the text in my solution and the original challenge text, I couldn't do the text formatting. I couldn't find anywhere about this. Any tips?
@rui-rmv
Posted
Hello, so you've added some additional padding to both the title and the description which is not present in the original. The originals are also placed in the center. Finally you should play with the font sizes to make the line breaks be exactly the same as in the original.
@Rchanis
Submitted
Any type of feedback is welcome. I feel I am improving this is my second challenge.
Should I use percentages instead of px for the grid?
@rui-rmv
Posted
So, good job on completing this challenge :) I have a few suggestions to you.
You did well to always use classes for stilling, but when choosing the class name, it should be meaningful and not related to styling (e.g. background_color is not a good name). Also please don't use capitalization on class names or underscores. Always write the class-names-like-this.
Remove the background_color div and add the corresponding style to the body tag.
Use a code formatter like Prettier (easy to use on VSCode)
Use a CSS reset sheet like this one: https://meyerweb.com/eric/tools/css/reset/. Your HTML shouldn't be used because of styling.
You did good to have the item-title as an h1 element and the item-description as a paragraph. For the price you could use a div since there really isn't any html tag with that meaning. You should strive to write semantic HTML
Marked as helpful
