Product preview card component

Community feedback

• 

  rui-rmv•20

  @rui-rmvPosted over 1 year ago

  So, good job on completing this challenge :) I have a few suggestions to you.

  1. You did well to always use classes for stilling, but when choosing the class name, it should be meaningful and not related to styling (e.g. background_color is not a good name). Also please don't use capitalization on class names or underscores. Always write the class-names-like-this.

  2. Remove the background_color div and add the corresponding style to the body tag.

  3. Use a code formatter like Prettier (easy to use on VSCode)

  4. Use a CSS reset sheet like this one: https://meyerweb.com/eric/tools/css/reset/. Your HTML shouldn't be used because of styling.

  5. You did good to have the item-title as an h1 element and the item-description as a paragraph. For the price you could use a div since there really isn't any html tag with that meaning. You should strive to write semantic HTML

  Marked as helpful

  1