@rstrong810Submitted over 3 years ago
Any feedback on my code or design is welcome. I am pretty new to web development so tips, tricks and best practices are what I'm looking for, thanks!
rstrong810
@rstrong810All comments
- @rstrong810Posted over 3 years ago
Right after I submitted this solution I saw a slight issue with the pledge amount not being displayed to the right for the desktop view on the main page's reward cards. I fixed it so my vercel site should reflect that
0 - @brasspetalsSubmitted over 3 years ago
Hi, everyone! 👋 Glad to finally be done with this one(I hope)!
Questions:
- When I uploaded my solution to Vercel, I noticed that on desktop the background image on the hero was loading slower and showing up halfway through the animation. I used this handy solution from CSS Tricks to pause the animations until the images were loaded. It seems to have worked for me, but let me know if there’s any weirdness. 🤞 Are there better ways to go about delaying animations until all elements are loaded?
- For accessibility, I again made sure to put the mobile menu button inside the nav, added an aria-label, as well as used the aria-expanded attribute as I did in the Loopstudios solution. Is this the correct way to go about this? Could accessibility be improved? Any insight is appreciated.
“Extras”
- The mobile menu will close if clicking outside the menu or header (as well as by using the menu button, of course).
- I played around with CSS animations on the hero section, with different animations for mobile and desktop.
Thanks for taking the time to look at my solution! Feedback is greatly appreciated. 😄
@rstrong810Posted over 3 years agoHello Anna, I am very impressed with your landing page. You did an amazing job putting it together. I just started learning web development about 6 months ago and after seeing what you did with this landing page I am inspired to keep learning. If you don't mind me asking, I was wondering how long you've been doing frontend development?
1
