@nikol-zimovaSubmitted 7 months ago
Robert Douglas
@robertdouglasaimonAll comments
- @robertdouglasaimonPosted 4 days ago
Your project is excellent, just adjust the proportion of the object and it will be perfect.
Try using the :root variable to allocate the project's colors, this prevents you from repeating RGBA and similar colors through CSS. It's easier to just call the variable and apply :)
0 - @ildi0818Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I think I'm starting to understand the essence of the mobile first and why we start coding with it first. Unfortunately, I didn't start with that, so it was more difficult. But it helped me understand.
What challenges did you encounter, and how did you overcome them?Dynamically scaling the image was a bit more difficult.
What specific areas of your project would you like help with?The sizing of the image caused minor difficulties in order to reduce its size proportionately. I could not remove the bottom line of the table, I only set the same color as the background. I tried to use a css variable, but I wasn't sure if I should assign it to, for example, "li".
@robertdouglasaimonPosted 7 months agoHello ildi0818! All good? I was looking at your project and it looked good!
I saw that you assigned
li { --color-li: hsl(24, 5%, 18%); }
because I was unsure about assigning variables in CSS. Always try to assign variables to the " :root {} " property. Because, in addition to being designed for this purpose, it helps you keep the code clean and organized (And you can assign both the colors and the fonts that you import with @import in it! It helps a lot!)
Ex of :root:
@import url('https://fonts.googleapis.com/css2?family=Young+Serif&display=swap');
:root { --font-Young-Serif:"Young Serif", serif; (for font) --cor1-Raspberry: hsl(332, 51%, 32%); (for color) }
I hope I helped, your project turned out really good! Congratulations!
Marked as helpful1 - @joeyturboSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
this was the first project without a figma file (i have a free account) and i think i managed to get everything sized up and proportional to the design file. i liked this project
What challenges did you encounter, and how did you overcome them?no big challenges.
What specific areas of your project would you like help with?none
@robertdouglasaimonPosted 7 months agoHonestamente, seu projeto ficou excelente! Única dica que eu daria agora era tentar acertar com o modelo (Digo altura, largura e etc..) e talvez evitar colocar sinais nas classes (_ , -, @, etc..), no mais, ta muito bom.
Bom trabalho! :)
Marked as helpful1 - @PedroP16Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Estoy feliz por haber podido realizarlo sin ninguna complicacion:
- De haber usado flex para centrar la card
- De poder manipular la imagen para que no se salga del contenedor
- Haber implementado los colores como variables
Personalmente no encontre ninguna dificultad, no es el primer Challenge que hago (Puede ser que haya errores y no lo sepa).
What specific areas of your project would you like help with?Me gustaria recibir ayuda en cualquier parte del codigo si se cree que se podria haber hecho de una mejor forma.
@robertdouglasaimonPosted 7 months agoGreat! :D
Now just adjust the color and size of the text and the size of the fonts.
A good job.
0 - @Sumaiya92Submitted 7 months ago@robertdouglasaimonPosted 7 months ago
Hello budy, how are you? Some tips that can help you! It would be nice if you separated the CSS from the HTML to keep the code clean. It would help you understand where you need to improve in the code.
In the 'body', the 100vh min-height is enough, you just need to adjust the display to flex, align the items in the middle with align-items: center. And here in the body itself, apply the font-size to the entire body as specified by the challenge: 15px.
You named a div in the style, but didn't specify which div it is. And applied several properties to this call, which was for almost all div's (There was a possible conflict). Due to the wrong DIV entry, it would be a good idea to adjust the div entry and the parameter indentation.
0
