Skip to content
OverviewSolutions
3
Comments
3
Roberto Cortez
@rob-the-automator

All comments

  • Roberto Cortez•50
    @rob-the-automatorPosted over 2 years ago

    Good job! I would try to change as many divs to semantic HTML tags. For example changing the container div to a <main> tag, the "centrado" div to <section> and the "attribution" div to <footer>. I would also change the h2 to and h1 again for semantic reasons. But other than that, it looks good!

    1
  • HectorPerez•40
    @hectorRperezSubmitted over 2 years ago

    I would be grateful if you would take a look at my project and leave me any recommendations

    I always have doubts regarding the file structure, if you have any improvements I would be grateful

    I always have doubts about my HTML structure, if you have any improvements I would be grateful

    Any recommendation adds 🔥🫂

    Solution for QR-code-component-challenge-hub

    1
    Roberto Cortez•50
    @rob-the-automatorPosted over 2 years ago

    Good job! I would replace the div with the attribution class to a footer and I would wrap the entire code in a <main> tag and I would change the h2 to an h1 for accessibility reasons.

    Marked as helpful
    0
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the Ping coming soon page.

    I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.

    You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.

    Thank you

    Ping coming soon page

    11
    Roberto Cortez•50
    @rob-the-automatorPosted over 2 years ago

    This looks great! One thing I noticed is that the 'Please provide an email address' popup disappears inconsistently. Sometimes it'll disappear after a couple milliseconds and sometimes it takes a few seconds to disappear. And on a 4k monitor the popup appears on the page mockup(right below the three buttons on the page mockup). But other than that, it looks amazing!

    0