Skip to content
Submitted over 2 years ago

Solution for QR-code-component-challenge-hub

HectorPerez•40
@hectorRperez
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would be grateful if you would take a look at my project and leave me any recommendations

I always have doubts regarding the file structure, if you have any improvements I would be grateful

I always have doubts about my HTML structure, if you have any improvements I would be grateful

Any recommendation adds 🔥🫂

Community feedback

  • Roberto Cortez•50
    @rob-the-automatorPosted over 2 years ago

    Good job! I would replace the div with the attribution class to a footer and I would wrap the entire code in a <main> tag and I would change the h2 to an h1 for accessibility reasons.

    Marked as helpful
    0
    HectorPerez•40
    @hectorRperezPosted over 2 years ago

    Thanks brodi, really if you are right @rob-the-automator

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord