All comments

• 

  Bradley Wright•80

  @rapidswingSubmitted almost 3 years ago

  Hello! Besides general comments and bug reports...

  • are there any React best practices or patterns I should look into?

  • my Redux game slice feels chunky, should I split it up?

  • any browser specific CSS/Sass styling errors?

  Thanks!

  Notes:

  • clicking the XO logo on either screen will access the difficulty settings

  • the modal is slightly transparent for game results to be visible through it

  

  Tic-Tac-Toe made with React, Redux Toolkit, and Sass

  1

  51
  

  Roman Zvir•290

  @rmzvrPosted almost 3 years ago

  Wow, great job, the code is well destructured, I like your writing style, I don't have enough redux knowledge to give hints yet. This project was next in my plans, maybe I will peep at your decision as inspiration)

  The only thing I noticed was hovering over the buttons on the welcome screen: When hovering over the side select buttons, the pointer appears on the X and O icons themselves, and not on the entire button. When hovering over the buttons, there is also no new game pointer, it is not visually clear whether these buttons are active.

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  minthing•145

  @minthingSubmitted over 3 years ago

  any feedback appreciated 🙏

  

  Frontend Mentor - Todo app

  1

  42
  

  Roman Zvir•290

  @rmzvrPosted over 3 years ago

  excellent work, I really like the result

  1

  This comment has received 1 replyShow
• 

  pierre-pellegrino•970

  @pierre-pellegrinoSubmitted over 3 years ago

  It was fun to make the toggle button controllable with arrow keys.

  

  Pricing component with toggle

  3

  40
  

  Roman Zvir•290

  @rmzvrPosted over 3 years ago

  oh good job, i like it)

  1

  This comment has received 1 replyShow